Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nwc info event to only include capabilities based on the app permissions #884

Merged
merged 6 commits into from
Dec 23, 2024
Merged

fix: nwc info event to only include capabilities based on the app permissions #884

merged 6 commits into from
Dec 23, 2024

Conversation

frnandu
Copy link
Contributor

@frnandu frnandu commented Dec 13, 2024 •
edited
Loading

fixes #766

@frnandu frnandu requested a review from rolznz December 13, 2024 20:19
@frnandu
Copy link
Contributor Author

frnandu commented Dec 14, 2024

Oh I forgot to update the event when permissions are edited. WiP

@rolznz rolznz marked this pull request as draft December 17, 2024 04:48
@frnandu frnandu marked this pull request as ready for review December 20, 2024 11:55
rolznz
rolznz approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@frnandu frnandu merged commit ad2d8dd into master Dec 23, 2024
9 checks passed
@frnandu frnandu deleted the fix/nwc-info-event-permissions branch December 23, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolznz rolznz rolznz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NIP-47 published info event should only include capabilities based on the app permissions
2 participants
@frnandu @rolznz