feat: get rid of invoice type

remove exposure of getInvoices via api
fix broken show more button for lndhub
signed-off-by: pavan joshi <pavanj914@gmail.com>

src/common/lib/api.ts

@@ -25,7 +25,6 @@ import type {
   LnurlAuthResponse,
   MessageAccountEdit,
   MessageAccountValidate,
-  MessageInvoices,
   MessageLnurlAuth,
   MessageSettingsSet,
   MessageTransactions,
@@ -171,8 +170,6 @@ export const unlock = (password: string) =>
   msg.request<UnlockRes>("unlock", { password });
 export const getBlocklist = (host: string) =>
   msg.request<BlocklistRes>("getBlocklist", { host });
-export const getInvoices = (options?: MessageInvoices["args"]) =>
-  msg.request<{ invoices: Invoice[] }>("getInvoices", options);
 export const getTransactions = (options?: MessageTransactions["args"]) =>
   msg.request<{ transactions: Invoice[] }>("getTransactions", options);
 export const lnurlAuth = (
@@ -298,7 +295,6 @@ export default {
   removeAccount,
   unlock,
   getBlocklist,
-  getInvoices,
   getTransactions,
   lnurlAuth,
   getCurrencyRate,

src/common/lib/utils.ts

@@ -1,12 +1,8 @@
 import browser, { Runtime } from "webextension-polyfill";
 import { ABORT_PROMPT_ERROR } from "~/common/constants";
 import { getPosition as getWindowPosition } from "~/common/utils/window";
-import type {
-  DeferredPromise,
-  Invoice,
-  OriginData,
-  OriginDataInternal,
-} from "~/types";
+import { ConnectorTransaction } from "~/extension/background-script/connectors/connector.interface";
+import type { DeferredPromise, OriginData, OriginDataInternal } from "~/types";
 
 const utils = {
   base64ToHex: (str: string) => {
@@ -173,7 +169,7 @@ const utils = {
     });
   },
   getBoostagramFromInvoiceCustomRecords: (
-    custom_records: Invoice["custom_records"] | undefined
+    custom_records: ConnectorTransaction["custom_records"] | undefined
   ) => {
     try {
       let boostagramDecoded: string | undefined;

src/extension/background-script/actions/ln/index.ts

@@ -1,7 +1,7 @@
 import checkPayment from "./checkPayment";
 import connectPeer from "./connectPeer";
 import getInfo from "./getInfo";
-import invoices from "./invoices";
+
 import keysend from "./keysend";
 import makeInvoice from "./makeInvoice";
 import request from "./request";
@@ -14,7 +14,6 @@ export {
   checkPayment,
   connectPeer,
   getInfo,
-  invoices,
   keysend,
   makeInvoice,
   request,

src/extension/background-script/actions/ln/transactions.ts

@@ -1,6 +1,7 @@
 import utils from "~/common/lib/utils";
+import { ConnectorTransaction } from "~/extension/background-script/connectors/connector.interface";
 import state from "~/extension/background-script/state";
-import type { Invoice, MessageTransactions } from "~/types";
+import type { MessageTransactions } from "~/types";
 
 const transactions = async (message: MessageTransactions) => {
   const isSettled = message.args.isSettled;
@@ -10,7 +11,7 @@ const transactions = async (message: MessageTransactions) => {
   try {
     const result = await connector.getTransactions();
 
-    let transactions: Invoice[] = result.data.transactions
+    let transactions: ConnectorTransaction[] = result.data.transactions
       .filter((transaction) =>
         isSettled ? transaction.settled : !transaction.settled
       )

src/extension/background-script/connectors/connector.interface.ts

@@ -137,7 +137,6 @@ export default interface Connector {
   unload(): Promise<void>;
   getInfo(): Promise<GetInfoResponse>;
   getBalance(): Promise<GetBalanceResponse>;
-  getInvoices(): Promise<GetInvoicesResponse>;
   getTransactions(): Promise<GetTransactionsResponse>;
   makeInvoice(args: MakeInvoiceArgs): Promise<MakeInvoiceResponse>;
   sendPayment(args: SendPaymentArgs): Promise<SendPaymentResponse>;

src/extension/background-script/connectors/lndhub.ts

@@ -157,7 +157,10 @@ export default class LndHub implements Connector {
         fee: string;
         keysend: boolean;
         memo: string;
-        payment_hash: string;
+        payment_hash: {
+          type: string;
+          data: ArrayBuffer;
+        };
         payment_preimage: string;
         r_hash: {
           type: "Buffer";
@@ -175,7 +178,9 @@ export default class LndHub implements Connector {
         id: `${index}`,
         memo: transaction.memo,
         preimage: transaction.payment_preimage,
-        payment_hash: transaction.payment_hash,
+        payment_hash: Buffer.from(transaction.payment_hash.data).toString(
+          "hex"
+        ),
         settled: true,
         settleDate: transaction.timestamp * 1000,
         totalAmount: transaction.value,

src/extension/background-script/router.ts

@@ -30,7 +30,6 @@ const routes = {
   lock: accounts.lock,
   unlock: accounts.unlock,
   getInfo: ln.getInfo,
-  getInvoices: ln.invoices,
   getTransactions: ln.transactions,
   sendPayment: ln.sendPayment,
   sendPaymentAsync: ln.sendPaymentAsync,

src/types.ts

@@ -342,10 +342,6 @@ export interface MessageAllowanceList extends MessageDefault {
   action: "listAllowances";
 }
 
-export interface MessageInvoices extends Omit<MessageDefault, "args"> {
-  args: { limit?: number; isSettled?: boolean };
-  action: "getInvoices";
-}
 export interface MessageTransactions extends Omit<MessageDefault, "args"> {
   args: { limit?: number; isSettled?: boolean };
   action: "getTransactions";