feat: add user_agent in default request options as well #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Nov 2, 2023
| @@ -89,7 +89,7 @@ export default class Alby implements Connector { | |||
|
|
|||
| async getInvoices(): Promise<GetInvoicesResponse> { | |||
| const incomingInvoices = (await this._request((client) => | |||
| client.incomingInvoices({}) | |||
| client.incomingInvoices({}, this._getRequestOptions()) | |||
There was a problem hiding this comment.
@pavanjoshi914 can you check if we can pass these options to the client so they don't need to be provided in every single request? best to keep it DRY
|
closing this in favor of #2843 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
add user agent in default request options. we added user agent in auth headers but not in default request options, pr addresses the same
Type of change
(Remove other not matching type)
feat: New feature (non-breaking change which adds functionality)Checklist