Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a replies table to store reply events #231

Closed
im-adithya opened this issue Jan 24, 2024 · 2 comments · Fixed by getAlby/nostr-wallet-connect-next#4
Closed

Add a replies table to store reply events #231

im-adithya opened this issue Jan 24, 2024 · 2 comments · Fixed by getAlby/nostr-wallet-connect-next#4

Comments

@im-adithya
Copy link
Member

Currently we only store the reply ID in the NostrEvent table (which are basically the received events of Kind NIP_47_REQUEST) after publishing a reply. Now that we are using an SQLite DB with #217, it's best to add a table to store these reply events early on to avoid having to migrate later.

Additional reasons are also mentioned here: #230

This also helps us in multi_methods (#218) as there we don't just have one reply per NostrEvent but multiple.

@rolznz
Copy link
Contributor

rolznz commented Jan 25, 2024

@im-adithya we need to do this as part of #217 right? I will add a TODO there

EDIT: it needs to be done as part of #218 right?

@im-adithya
Copy link
Member Author

Done here: getAlby#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants