Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multi pay invoice method #218

Closed
wants to merge 13 commits into from
Closed

feat: add multi pay invoice method #218

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5962c6b
feat: add multi pay invoice method
im-adithya Jan 16, 2024
ddbe70d
chore: publish in multi handler
im-adithya Jan 17, 2024
09ae1fb
chore: refactoring
im-adithya Jan 18, 2024
b1a43fe
chore: DRY up dtag usage
im-adithya Jan 18, 2024
3fad688
fix: issues with multi_pay_invoice
rolznz Jan 22, 2024
dad7b90
chore: use sync mutex for concurrency support
im-adithya Jan 22, 2024
451f7d6
fix: add one second to oauth token expiry check
rolznz Jan 23, 2024
1e3d720
chore: split handleUnknownMethod function, add TODO about inconsisten…
rolznz Jan 23, 2024
3e8f41c
chore: fix tests
im-adithya Jan 24, 2024
560b226
chore: add todos
im-adithya Jan 25, 2024
4b8f608
Merge branch 'feat/wails-v2' into task-multi-pay
im-adithya Jan 25, 2024
b86ff49
fix: same event id in tests
im-adithya Jan 25, 2024
01786f8
chore: remove test for backwards compatibility
im-adithya Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,9 @@ func (svc *Service) handleAndPublishEvent(ctx context.Context, sub *nostr.Subscr
}).Errorf("Failed to process event: %v", err)
return
}

// TODO: consider move event publishing to individual methods - multi_* methods are
// inconsistent with single methods because they publish multiple responses
switch nip47Request.Method {
case NIP_47_MULTI_PAY_INVOICE_METHOD:
svc.HandleMultiPayInvoiceEvent(ctx, sub, nip47Request, event, app, ss)
Expand All @@ -233,12 +236,7 @@ func (svc *Service) handleAndPublishEvent(ctx context.Context, sub *nostr.Subscr
case NIP_47_GET_INFO_METHOD:
resp, err = svc.HandleGetInfoEvent(ctx, nip47Request, event, app, ss)
default:
resp, err = svc.createResponse(event, Nip47Response{
ResultType: nip47Request.Method,
Error: &Nip47Error{
Code: NIP_47_ERROR_NOT_IMPLEMENTED,
Message: fmt.Sprintf("Unknown method: %s", nip47Request.Method),
}}, nostr.Tags{}, ss)
resp, err = svc.handleUnknownMethod(ctx, nip47Request, event, app, ss)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

}

if err != nil {
Expand All @@ -252,6 +250,15 @@ func (svc *Service) handleAndPublishEvent(ctx context.Context, sub *nostr.Subscr
}
}

func (svc *Service) handleUnknownMethod(ctx context.Context, request *Nip47Request, event *nostr.Event, app App, ss []byte) (result *nostr.Event, err error) {
return svc.createResponse(event, Nip47Response{
ResultType: request.Method,
Error: &Nip47Error{
Code: NIP_47_ERROR_NOT_IMPLEMENTED,
Message: fmt.Sprintf("Unknown method: %s", request.Method),
}}, nostr.Tags{}, ss)
}

func (svc *Service) createResponse(initialEvent *nostr.Event, content interface{}, tags nostr.Tags, ss []byte) (result *nostr.Event, err error) {
payloadBytes, err := json.Marshal(content)
if err != nil {
Expand Down
Loading