feat: "solve" updates #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use appmap-python script to enable appmapping - Use subprocess.run directly to run the indexer
Propagate variables that are needed by the solver. Remove global variable.
kgilpin
commented
Jun 3, 2024
| run( | ||
| [ | ||
| "python", | ||
| abspath(args.solver_path), |
There was a problem hiding this comment.
args.solver_path was not propagated without the changes in this commit. Neither was args.appmap_command.
kgilpin
commented
Jun 3, 2024
| issue_dir.mkdir(parents=True, exist_ok=True) | ||
| issue_file = issue_dir / "issue.txt" | ||
| with open(issue_file, "w") as f: | ||
| f.write(instance["problem_statement"]) |
There was a problem hiding this comment.
The primary reason for putting this information in a directory is that the logs will remain available - and there can be a lot of logs per issue that are very useful to pick through if something doesn't go right.
kgilpin
commented
Jun 3, 2024
| @@ -68,6 +75,7 @@ def solve_instances(instances, args): | |||
| { | |||
| "task_instances": g, | |||
| "func": solve_instance, | |||
| "output_file": args.output, | |||
There was a problem hiding this comment.
Alias output to output_file.
kgilpin
commented
Jun 3, 2024
| solve_instances(dataset, args) | ||
|
|
||
| if __name__ == "__main__": | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument( | ||
| "--instances_path", |
There was a problem hiding this comment.
instances_path is the name of this option in all the other scripts.
dustinbyrne
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.