Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple media GET requests should not be saved as request recordings #256

Open
brikelly opened this issue Oct 13, 2023 · 1 comment
Open

Simple media GET requests should not be saved as request recordings #256

brikelly opened this issue Oct 13, 2023 · 1 comment
Labels
appmap-python bug Something isn't working

Comments

@brikelly
Copy link
Contributor

brikelly commented Oct 13, 2023 •
edited
Loading

I mapped a simple Flask app with request recording, and saw this output:

Image

The requests for GET requests for favicons, CSS, JS assets, etc should not be saved as maps. That's extra work for the indexer and scanner and it creates noise in the UI in the list of AppMaps for that project.
@brikelly brikelly added bug Something isn't working appmap-python labels Oct 13, 2023
@virajkanwade
Copy link
Contributor

@apotterri i wouldn't call this a bug. More like a feature enhancement where it's a config flag to enable/disable the media requests tracking.
Somebody might actually want to track media requests.

virajkanwade added a commit to virajkanwade/appmap-python that referenced this issue Feb 29, 2024
@virajkanwade
[getappmap#256] Flag to disable static request recording "APPMAP_ENAB…
a2dcea3 
…LED_STATIC_REQUEST_RECORDINGS"
virajkanwade added a commit to virajkanwade/appmap-python that referenced this issue Feb 29, 2024
@virajkanwade
[getappmap#256] Flag to disable static request recording "APPMAP_ENAB…
b4f84e5 
…LED_STATIC_REQUEST_RECORDINGS"
virajkanwade added a commit to virajkanwade/appmap-python that referenced this issue Mar 15, 2024
@virajkanwade
[getappmap#256] Flag to disable static request recording "APPMAP_ENAB…
8247752 
…LED_STATIC_REQUEST_RECORDINGS"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
appmap-python bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@virajkanwade @brikelly