Add FastAPI support #282
Closed
Add FastAPI support #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apotterri
force-pushed
the
fastapi_20240216
branch
3 times, most recently
from
04c82cc
to
91a65e0
Compare
3.7 was EOLed 27-Jun-2023.
apotterri
force-pushed
the
fastapi_20240216
branch
from
91a65e0
to
449c40a
Compare
Adding some typing revealed some issues, fix them.
In spite of the stand library's assertion that it provides all the log levels needed, it really seems useful to have a TRACE level. Add it, and cut down some of the cruft logged at DEBUG.
apotterri
force-pushed
the
fastapi_20240216
branch
5 times, most recently
from
1286f3e
to
9e529a2
Compare
Make sure an exception in a Flask route handler gets recorded. Also, refactor web_framework a bit.
Flask v1 has been EOLed for a really long time. Flask 3 is out now, which means Flask v2 is also EOL. All the tests still pass, though, so we can continue supporting it for at least a little while.
pylint exits non-zero, even if there were no errors. pylint-exit interprets the error code, and exits with shell-friendly code.
Installing the rust toolchain takes a long time (especially in the 3.10 job, for some reason). The Travis doc says `cargo: true` will cache $HOME/.cargo, which should help.
apotterri
force-pushed
the
fastapi_20240216
branch
from
247f24b
to
67cc779
Compare
Closed
|
Closing this in favor of #287 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add some typing revealed some issues, fix them.