Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable recording by default #305

Merged
merged 5 commits into from
May 23, 2024
Merged

disable recording by default #305

merged 5 commits into from
May 23, 2024

Commits on May 21, 2024

  1. fix: honor APPMAP_RECORD_REQUESTS when testing

    Make sure `APPMAP_RECORD_REQUESTS=true` will generate request recordings
    when running tests. Previously, it was ignored, and request recordings
    were never generated when tests were run.
    apotterri committed May 21, 2024
    Configuration menu
    Copy the full SHA
    2df0f37 View commit details
    Browse the repository at this point in the history
  2. fix: combine testing-related env vars

    Combine APPMAP_RECORD_PYTEST and APPMAP_RECORD_UNITTEST into
    APPMAP_RECORD_TESTS.
    apotterri committed May 21, 2024
    Configuration menu
    Copy the full SHA
    500fe55 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. refactor: rename doc to docs

    Also, fix a typo.
    apotterri committed May 23, 2024
    Configuration menu
    Copy the full SHA
    aa89150 View commit details
    Browse the repository at this point in the history
  2. feat: disable record by default

    Recording is no longer enabled by default. It is now necessary to run scripts with
    appmap-python, or explicitly set APPMAP=true
    
    BREAKING CHANGE: disable record by default
    apotterri committed May 23, 2024
    Configuration menu
    Copy the full SHA
    57b3910 View commit details
    Browse the repository at this point in the history
  3. fix: enabling process recording disables others

    It doesn't make sense (and doesn't work) to try to capture other
    recording types when the user says they want a process recording (by
    setting APPMAP_RECORD_PROCESS=true).
    apotterri committed May 23, 2024
    Configuration menu
    Copy the full SHA
    74b2ee1 View commit details
    Browse the repository at this point in the history