fix: appmap.Recording is available even when APPMAP=false #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zermelo-wisen
force-pushed
the
fix/import-recording-when-not-enabled
branch
4 times, most recently
from
b58c807
to
325a58b
Compare
zermelo-wisen
force-pushed
the
fix/import-recording-when-not-enabled
branch
from
325a58b
to
6affac6
Compare
apotterri
requested changes
May 30, 2024
ci/smoketest.sh
Outdated
| @@ -27,3 +27,22 @@ else | |||
| find $PWD | |||
| exit 1 | |||
| fi | |||
|
|
|||
| # Ensure that client code using appmap.Recording does not fail when APPMAP=false | |||
There was a problem hiding this comment.
This can get moved up before https://github.com/getappmap/appmap-python/pull/327/files#diff-ba2ff002750238ee03b3467fd4400804141c8aa2606bdd4263f0a3636bb120c1R12 to avoid flipping APPMAP on and off.
This file is starting to get kind of complicated. Please move this test into a separate function. Thanks!
zermelo-wisen
force-pushed
the
fix/import-recording-when-not-enabled
branch
from
6affac6
to
d7c522e
Compare
zermelo-wisen
force-pushed
the
fix/import-recording-when-not-enabled
branch
from
d7c522e
to
6bb7687
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #326.
NoopRecordingclass with the same interface asRecording.NoopRecordingasRecordingwhenAPPMAPis not set totrueto prevent "ImportError: cannot import name 'Recording' from 'appmap' ..." in client code.smoketest.shto ensure that client code usingappmap.Recordingdoes not fail whenAPPMAP=false.