fix: request recording in unittest setUp method #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apotterri
requested changes
Jun 19, 2024
| @@ -213,7 +213,7 @@ def test_enabled(self, pytester): | |||
| def test_disabled(self, pytester, monkeypatch): | |||
| monkeypatch.setenv("_APPMAP", "false") | |||
| result = pytester.runpytest("-svv", "-p", "no:randomly", "-k", "test_request") | |||
| result.assert_outcomes(passed=1, failed=0, errors=0) | |||
| result.assert_outcomes(passed=2, failed=0, errors=0) | |||
There was a problem hiding this comment.
This also needs to check that no request recordings were created.
There was a problem hiding this comment.
Doesn't the following line assert that as well?
appmap-python/_appmap/test/test_django.py
Line 217 in f90ca45
There was a problem hiding this comment.
Well, it does, in the case that APPMAP=false (i.e. recording is completely disabled). The test I asked for ensures that request recordings aren't generated when other AppMaps are.
zermelo-wisen
force-pushed
the
fix/request-recording-in-unittest-setup
branch
from
f90ca45
to
1ee69cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #332
unittestTestCase._callSetUpmethod to disable request recording in order to prevent the creation of a request recording when a request is made insidesetUpmethod of aunittesttest.unittesttest todjangofixture project which makes a request insidesetUpmethod. This test makes thetest_django.py::TestDjangoApp::test_enabledpass with the fix and fail without the fix.djangoproject:$ APPMAP=TRUE ./runtests.py auth_tests.test_views.ChangelistTests.test_user_change_emailA request made inside
ChangelistTests.setUpmethod leads to the creation of requests recording AppMap without the fix.