fix: appmap breaks vscode python extension starting a REPL #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apotterri
requested changes
Jun 17, 2024
_appmap/test/test_env.py
Outdated
| @@ -11,3 +12,17 @@ def test_disable_temporarily(): | |||
| except RuntimeError: | |||
| ... | |||
| assert env.enables("requests") | |||
|
|
|||
| def test_determine_log_file(monkeypatch): | |||
| env = Env({"_APPMAP": "true"}) | |||
There was a problem hiding this comment.
Did you check to see if APPMAP was really "true" when you were investigating #339? I don't think it should have been.
_appmap/test/test_env.py
Outdated
|
|
||
| def test_determine_log_file(monkeypatch): | ||
| env = Env({"_APPMAP": "true"}) | ||
|
|
There was a problem hiding this comment.
I think it's important to add an end-to-end test that actually shows that the behavior described in #339 is fixed. It would be ideal to add this to the smoketest, but that's going to be complicated by the fact that processes in docker run as root.
Can you give some thought to how we might implement such a test, please?
zermelo-wisen
force-pushed
the
fix/appmap-breaks-python-extension-repl
branch
19 times, most recently
from
be47434
to
088dfa7
Compare
zermelo-wisen
force-pushed
the
fix/appmap-breaks-python-extension-repl
branch
from
088dfa7
to
c179b86
Compare
apotterri
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339.
appmap.logfile for logging, since a file system read-only error can occur in the [VSCode Python Extension, Virtual Environment, REPL, Shift Enter] scenario when attempting to create the log file.appmap.logfile to Docker and adds a test to the smoke test suite for running with a non-modifiableappmap.log.