Fix tests that fail with numpy v2 #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an actual appmap doesn't match the expected one, show it as JSON to make it easier to understand why they're different (and to assist with updating the expected, if appropriate).
apotterri
force-pushed
the
numpy2_20240702
branch
2 times, most recently
from
61bd1b8
to
aebd259
Compare
With the previous function in simple.py, the return event generated to check that numpy.int64 serialized correctly didn't test AppMapEncoder. Keys in a dict that are in a return event are rendered with "repr" before the event gets serialized. "repr(int64(0))" returned "0" in 1.x, but returns "numpy.int64(0)" in 2.x, which caused the test to fail.
apotterri
force-pushed
the
numpy2_20240702
branch
from
aebd259
to
231af72
Compare
zermelo-wisen
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous function in simple.py, the return event generated to
check that numpy.int64 serialized correctly didn't test AppMapEncoder.
Keys in a dict that are in a return event are rendered with "repr"
before the event gets serialized. "repr(int64(0))" returned "0" in 1.x,
but returns "numpy.int64(0)" in 2.x, which caused the test to fail.
It's (almost certainly) inconsistent that types appear verbatim in call events, and are rendered using "repr" in return events. Changing that will probably have broad implications, so this PR doesn't attempt to address that.
Fixes #345 .