Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate use of defaultdict for resources section handling in config. #13

Open
em-pe opened this issue Mar 24, 2022 · 1 comment
Open
Labels
nice to have It would be nice to have but it's not urgent.

Comments

@em-pe
Copy link
Member

em-pe commented Mar 24, 2022

What about using from collections import defaultdict with
resources: Optional[Dict[str, ResourcesConfig]] = defaultdict(lambda: ResourcesConfig(cpu="500m", memory="1024Mi"))

it would also simplify (or even make not needed) the resources_for function.

Originally posted by @marrrcin in #11 (comment)

@em-pe em-pe added the nice to have It would be nice to have but it's not urgent. label Mar 24, 2022
@Lasica
Copy link
Contributor

Lasica commented Nov 22, 2023

It could simplify it a bit but it currently does some more work. It think it makes sense to rethink a bit resources configuration to enable changing all of the available params (including docker images if one wishes to) #129

We may need to have a fresh look at this as we have grouping nodes as a feature to consider as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice to have It would be nice to have but it's not urgent.
Projects
None yet
Development

No branches or pull requests

2 participants