refactor: use URL.canParse to check if string is URL

getindiekit · Jan 16, 2024 · 48842e9 · 48842e9
1 parent e8d5eff
commit 48842e9
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 43 deletions.
diff --git a/lib/fetch-references.js b/lib/fetch-references.js
@@ -1,6 +1,5 @@
 import { mf2tojf2 } from "../index.js";
 import { fetchMf2 } from "./fetch-mf2.js";
-import { isUrl } from "./is-url.js";
 
 /**
  * Get a list of URLs that can be referenced
@@ -15,7 +14,7 @@ const referenceableUrls = (jf2) => {
     if (Object.prototype.hasOwnProperty.call(jf2, key)) {
       const value = jf2[key];
 
-      if (typeof value === "string" && isUrl(value) && key !== "url") {
+      if (typeof value === "string" && URL.canParse(value) && key !== "url") {
         urls.push(value);
       }
     }

diff --git a/lib/is-url.js b/lib/is-url.js
diff --git a/test/is-url.js b/test/is-url.js