Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the reference implementation ignores fetching references for the
url
property, this being the URL of the source post.In testing, a media endpoint can return a fully resolved URL to a photo (or other media item); this can then get referenced, which doesn’t really make much sense, and doesn’t add any useful information. Example:
What happened here was that Indiekit’s media endpoint returned a fully resolved URL for the media item, and then the post template updated the URL for
photo
to be a relative path to the file. However, somewhere in the flow of things, the URL for the photo got referenced and appended to the post properties.This PR adds
audio
,photo
andvideo
properties tourl
to a list of properties to ignore, and thus never seek to get reference data for.@aciccarello; am going to publish this in the next minor release, can refine in subsequent releases if you think I may have got this wrong.