Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Bedrock and Bedrock Agents #7597

Merged
merged 6 commits into from
Apr 27, 2024
Merged

Conversation

JoshLevyMN
Copy link
Contributor

@JoshLevyMN JoshLevyMN commented Apr 15, 2024

Support for Bedrock and Agents for Bedrock services.
Includes support for create, delete, list, get, and tagging operations for custom models, model customization jobs, model invocation logging, agents, and knowledge bases.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JoshLevyMN, thanks for the PR! Please see my comments.

I haven't gone through the tests yet, but I'll do that on a second/third pass.

moto/bedrock/models.py Outdated Show resolved Hide resolved
moto/bedrock/models.py Show resolved Hide resolved
moto/bedrockagent/responses.py Outdated Show resolved Hide resolved
moto/bedrockagent/urls.py Outdated Show resolved Hide resolved
moto/bedrockagent/responses.py Outdated Show resolved Hide resolved
moto/bedrockagent/responses.py Outdated Show resolved Hide resolved
@JoshLevyMN
Copy link
Contributor Author

Thanks for the feedback @bblommers, it should all be addressed now.
All of the testserver tests are failing, and I'm not sure how to fix it.

@bblommers
Copy link
Collaborator

Hi @JoshLevyMN, I believe the ServerMode tests are failing because of a bug with how Moto handles request matching. I'll fix that first, and then revisit this. All the changes LGTM btw!

@bblommers bblommers added this to the 5.0.6 milestone Apr 27, 2024
@bblommers bblommers merged commit f58a575 into getmoto:master Apr 27, 2024
9 of 14 checks passed
@moto-payments-app
Copy link

Hi @JoshLevyMN,

Thank you again for contributing to Moto!

PR's like this are the big reason that Moto is as successful as it is - so it's only fair that you, as a contributor, gets to share the spoils. Therefore, to show our thanks, we'd like to share some of the donations that we've received with you.

We've created a companion website with more information:
https://payments.getmoto.org/

Feel free to open a bug or discussion if you run into any problems:
https://github.com/getmoto/payments

Copy link
Contributor

This is now part of moto >= 5.0.6.dev41

jfmainville pushed a commit to jfmainville/moto that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants