Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Techdebt: Refactor request-handling AWSLambda #7631

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Techdebt: Refactor request-handling AWSLambda #7631

merged 1 commit into from
Apr 25, 2024

Conversation

bblommers
Copy link
Collaborator

Fixes #7628

@bblommers bblommers added the moto-core PR's that touch the core functionality. This will trigger additional tests. label Apr 25, 2024
@bblommers bblommers added this to the 5.0.6 milestone Apr 25, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 94.25%. Comparing base (9aef694) to head (1f93917).
Report is 204 commits behind head on master.

Files Patch % Lines
moto/awslambda/responses.py 96.63% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7631      +/-   ##
==========================================
- Coverage   95.88%   94.25%   -1.63%     
==========================================
  Files         843     1072     +229     
  Lines       82578    91916    +9338     
==========================================
+ Hits        79178    86638    +7460     
- Misses       3400     5278    +1878
Flag Coverage Δ
servertests 29.51% <6.06%> (-3.01%) ⬇️
unittests 94.22% <96.96%> (-1.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit 5ae2a82 into getmoto:master Apr 25, 2024
76 of 77 checks passed
@bblommers bblommers deleted the techdebt/lambda-refactor-requests branch April 25, 2024 20:32
@github-actions GitHub Actions
Copy link
Contributor

This is now part of moto >= 5.0.6.dev36

jfmainville pushed a commit to jfmainville/moto that referenced this pull request Jun 25, 2024
@bblommers @jfmainville
Techdebt: Refactor request-handling AWSLambda (getmoto#7631)
d980900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
moto-core PR's that touch the core functionality. This will trigger additional tests.
Projects
None yet
Milestone
5.0.6
Development

Successfully merging this pull request may close these issues.
1 participant
@bblommers