Prep release 5.0.8 #7718
Merged
Prep release 5.0.8 #7718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7718 +/- ##
=======================================
Coverage 94.33% 94.33%
=======================================
Files 1092 1092
Lines 93033 93036 +3
=======================================
+ Hits 87762 87768 +6
+ Misses 5271 5268 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bblommers
added
the
moto-core
bblommers
added
moto-core
|
This is now part of moto >= 5.0.8.dev23 |
jfmainville
pushed a commit
to jfmainville/moto
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts ##7713 and #7715 - now that there is a new Docker release, the latest requests-module no longer breaks. (docker/docker-py#3256)
A few days ago the
awsterraform provider was updated from5.50.0to5.51.0. This broke our Terraform tests for ACM and Route53. More specifically, a call toChangeResourceRecordSetssuddenly no longer worked.The underlying problem is that Terraform used to make a POST request to
/2013-04-01/hostedzone/<id>/rrset/, but with the5.51.0release would make a request to/2013-04-01/hostedzone/<id>/rrset(without trailing slash).It's safe to assume that AWS allows both versions, so this PR also changes our logic to also allow both versions of this particular URL.
(A first iteration made all leading slashes optional, to make it a more general solution - but that broke URL interception for the Backup-service)