fix: make home_directory_mappings arg for Transfer's create_user() optional #7957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7957 +/- ##
=======================================
Coverage 94.36% 94.36%
=======================================
Files 1120 1120
Lines 96060 96064 +4
=======================================
+ Hits 90646 90650 +4
Misses 5414 5414
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bblommers
approved these changes
Aug 10, 2024
|
This is now part of moto >= 5.0.13.dev32 |
|
Thank you @bblommers — do you know when v5.0.13 will be released? |
|
@jenstroeger There is nothing set in stone yet, but I'll can probably get that done next weekend. |
That’d be great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #7790 and PR #7891, in particular comment #7891 (comment). Tagging @bblommers and @armichaud.
The
HomeDirectoryMappingsargument for the Transfer client’screate_user()function is not marked as required, i.e. it’s optional, and should be typed & handled as such. Docs here.Refs: 416e304