Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Techdebt: S3: Untangle GET-methods #8000

Merged

Conversation

bblommers
Copy link
Collaborator

@bblommers bblommers commented Aug 19, 2024

No logical changes - this just untangles the massive _key_response_get-method in S3Response.

The end-goal here is to get rid of the if ".." in querystring.. spaghetti altogether, and let our regular dispatch method handle the dispatching, but there are several steps that need to be handled first:

  1. untangle POST/PUT/DELETE requests
  2. ensure dispatch() can handle querystrings
  3. ensure dispatch() knows and can handle the difference between virtual-host and path-style URL's
  4. change s3/urls.py to use dispatch
  5. and then we can remove all if ".." in querystring sections

@bblommers bblommers added this to the 5.0.14 milestone Aug 19, 2024
@bblommers bblommers added dependency-management moto-core PR's that touch the core functionality. This will trigger additional tests. and removed dependency-management labels Aug 19, 2024
@bblommers bblommers force-pushed the techdebt/untangle-s3-get-methods branch 2 times, most recently from 23ef5c3 to 6ac555c Compare August 19, 2024 17:13
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 97.37991% with 6 lines in your changes missing coverage. Please review.

Project coverage is 94.38%. Comparing base (fc60bd1) to head (d280ac7).
Report is 4 commits behind head on master.

Files Patch % Lines
moto/s3/responses.py 97.29% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8000   +/-   ##
=======================================
  Coverage   94.38%   94.38%           
=======================================
  Files        1130     1130           
  Lines       96587    96633   +46     
=======================================
+ Hits        91159    91205   +46     
  Misses       5428     5428           
Flag Coverage Δ
servertests 28.98% <47.16%> (+0.10%) ⬆️
unittests 94.35% <97.37%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers added moto-core PR's that touch the core functionality. This will trigger additional tests. and removed moto-core PR's that touch the core functionality. This will trigger additional tests. labels Aug 19, 2024
@bblommers bblommers force-pushed the techdebt/untangle-s3-get-methods branch from 6ac555c to 466202e Compare August 19, 2024 18:45
@bblommers bblommers added moto-core PR's that touch the core functionality. This will trigger additional tests. and removed moto-core PR's that touch the core functionality. This will trigger additional tests. labels Aug 19, 2024
@bblommers bblommers force-pushed the techdebt/untangle-s3-get-methods branch from 466202e to d280ac7 Compare August 19, 2024 20:32
@bblommers bblommers added moto-core PR's that touch the core functionality. This will trigger additional tests. and removed moto-core PR's that touch the core functionality. This will trigger additional tests. labels Aug 19, 2024
@bblommers bblommers merged commit d361b67 into getmoto:master Aug 19, 2024
85 of 87 checks passed
@bblommers bblommers deleted the techdebt/untangle-s3-get-methods branch August 19, 2024 21:39
Copy link
Contributor

This is now part of moto >= 5.0.14.dev6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
moto-core PR's that touch the core functionality. This will trigger additional tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant