Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Techdebt: Untangle S3 DELETE-methods #8044

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

bblommers
Copy link
Collaborator

Followup to #8000

@bblommers bblommers added this to the 5.0.14 milestone Aug 27, 2024
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 95.16129% with 3 lines in your changes missing coverage. Please review.

Project coverage is 94.43%. Comparing base (5581aa4) to head (8b98aa0).
Report is 4 commits behind head on master.

Files Patch % Lines
moto/s3/responses.py 95.08% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8044      +/-   ##
==========================================
+ Coverage   94.41%   94.43%   +0.01%     
==========================================
  Files        1134     1139       +5     
  Lines       96832    97349     +517     
==========================================
+ Hits        91424    91930     +506     
- Misses       5408     5419      +11     
Flag Coverage Δ
servertests 28.92% <24.19%> (-0.08%) ⬇️
unittests 94.40% <95.16%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers merged commit abfd667 into getmoto:master Aug 27, 2024
50 checks passed
@bblommers bblommers deleted the techdebt-s3-delete-methods branch August 27, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant