Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspaces Web User Settings Support #8134

Merged
merged 3 commits into from
Sep 21, 2024

Conversation

jamarcelin
Copy link
Contributor

No description provided.

@jamarcelin
Copy link
Contributor Author

@bblommers Hello! Any idea how to fix this linting issue? The line with the # type: ignore[misc] keeps getting moved around by the formatter.

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (b95bfe9) to head (2089d4c).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #8134    +/-   ##
========================================
  Coverage   94.49%   94.50%            
========================================
  Files        1150     1150            
  Lines       99025    99177   +152     
========================================
+ Hits        93571    93723   +152     
  Misses       5454     5454            
Flag Coverage Δ
servertests 28.79% <14.38%> (-0.03%) ⬇️
unittests 94.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for adding this to Moto @jamarcelin!

@bblommers bblommers added this to the 5.0.15 milestone Sep 21, 2024
@bblommers bblommers merged commit 9531ffb into getmoto:master Sep 21, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants