-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): Bump Dockerfile base image to node:20-bookworm #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
force-pushed
the
neel/bump-debian
branch
from
July 12, 2023 15:21
66121cd
to
84a6012
Compare
ok well the cloudbuild fails with kaniko, but not with docker locally
there's stuff like this around |
bumped kaniko to latest and it worked |
sl0thentr0py
changed the title
feat(build): Bump Dockerfile base image to node:20-bookwork
feat(build): Bump Dockerfile base image to node:20-bookworm
Jul 13, 2023
sl0thentr0py
force-pushed
the
neel/bump-debian
branch
from
July 13, 2023 08:45
3d65cef
to
15cb713
Compare
oioki
approved these changes
Jul 17, 2023
mydea
added a commit
that referenced
this pull request
Jul 18, 2023
* Revert "ref: add python3-packaging explicitly (#474)" This reverts commit ddd80e5. * Revert "fix(hex): Add erlang-dev for missing parsetools (#473)" This reverts commit edf83d2. * Revert "feat(build): Bump Dockerfile base image to node:20-bookworm (#472)" This reverts commit 0941c46. --------- Co-authored-by: anthony sottile <103459774+asottile-sentry@users.noreply.github.com> Co-authored-by: Neel Shah <neel.shah@sentry.io>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed this because
elixir
version on bullseye was too old.version diff
ran the following inside container on both master and this branch