Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maven): Rename module.json to dist.module #540

Merged
merged 1 commit into from
May 23, 2024

Conversation

markushi
Copy link
Member

Currently various SDKs (sentry-java, kotlin multiplatform) generate maven ready artifacts which contain a module.json file instead of a e.g. sentry-java-1.0.0.module file.

This PR simply renames the file right before publishing to maven.

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the tests!

@markushi markushi merged commit de86d16 into master May 23, 2024
8 checks passed
@markushi markushi deleted the fix/missing-module-file branch May 23, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants