fix(maven): move importGPGKey function call from constructor to publish
#553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context We have recently set up a multiple target setup in one of our repos: https://github.com/getsentry/sentry-kotlin-multiplatform/blob/main/.craft.yml and noticed an error during publish that indicates an error within the `importGPGKey` function: https://github.com/getsentry/publish/actions/runs/10250810494/job/28357374501#step:11:166 ## Fix The `importGPGKey` function returns a promise but is not being awaited Side note: shouldn't this be caught by some static code analyzer or linter?
buenaflor
changed the title
importGPGKey function callimportGPGKey function call from constructor to publish
HazAT
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We have recently set up a multiple maven target setup in one of our repos: https://github.com/getsentry/sentry-kotlin-multiplatform/blob/main/.craft.yml
and noticed an error during publish that indicates an error within the
importGPGKeyfunction: https://github.com/getsentry/publish/actions/runs/10250810494/job/28357374501#step:11:166Fix
The
importGPGKeyfunction returns a promise but is not being awaited in the constructor (which is problematic when multiple targets are instantiated) and it cannot be awaited in a constructor so we move it to the publish call site