Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(maven): move importGPGKey function call from constructor to publish #553

Merged
merged 5 commits into from
Aug 8, 2024
Merged

fix(maven): move importGPGKey function call from constructor to publish #553

merged 5 commits into from
Aug 8, 2024

Commits on Aug 6, 2024

  1. fix: add missing await to importGPGKey function call 

    ## Context
We have recently set up a multiple target setup in one of our repos: https://github.com/getsentry/sentry-kotlin-multiplatform/blob/main/.craft.yml

and noticed an error during publish that indicates an error within the `importGPGKey` function: https://github.com/getsentry/publish/actions/runs/10250810494/job/28357374501#step:11:166

## Fix

The `importGPGKey` function returns a promise but is not being awaited

Side note: shouldn't this be caught by some static code analyzer or linter?
    @buenaflor
    buenaflor committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    d713cac View commit details
    Browse the repository at this point in the history

  2. move to publish

    @buenaflor
    buenaflor committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    cf47fd2 View commit details
    Browse the repository at this point in the history

  3. fix test

    @buenaflor
    buenaflor committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    8572d00 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. revert some formatting

    @buenaflor
    buenaflor committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    5c7f6f9 View commit details
    Browse the repository at this point in the history

  2. add missing newline

    @buenaflor
    buenaflor committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    88351e6 View commit details
    Browse the repository at this point in the history