feat: Add #body-in-changelog option to PR/commit bodies #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now this is manually done by the getsentry/sentry-python team. I thought it was a good opportunity improve automatic changelog generation. Thanks to @sentrivana for the idea.
| remote: { | ||
| number: '456', | ||
| author: { login: 'bob' }, | ||
| body: `This is important and we'll include the __body__ for attention. ${BODY_IN_CHANGELOG_MAGIC_WORD}`, |
There was a problem hiding this comment.
Should this be expected in the output?
There was a problem hiding this comment.
Nope. This is a "trick case" where it still gets folded up in the associated milestone.
Should probably clarify the text to express this then.
| hasPRinTitle: boolean; | ||
| pr: string | null; | ||
| prBody?: string | null; |
There was a problem hiding this comment.
is this used anywhere? seems like it is always undefined
There was a problem hiding this comment.
Comes from the spread GitHub API response somewhere in the code.
hubertdeng123
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now this is manually done by the getsentry/sentry-python team. I thought it was a good opportunity improve automatic changelog generation. Thanks to @sentrivana for the idea.