This repository has been archived by the owner on Aug 14, 2024. It is now read-only.
docs(crons): Document check-in envelope size limit #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jjbayer
approved these changes
Nov 16, 2023
| @@ -600,6 +600,7 @@ These limits are subject to future change and defined currently as: | |||
| - *1MB* for event and transaction Items | |||
| - *100 sessions* per Envelope | |||
| - *100 pre-aggregated session buckets* per each `"sessions"` Item | |||
| - *100KB* for monitor Check-ins | |||
There was a problem hiding this comment.
nit: is lowercase 'monitor' and uppercase 'Check-in' the spelling we want?
There was a problem hiding this comment.
i thought it was odd but i'm just going off of the convention in the bullet points above
cleptric
approved these changes
Nov 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents maximum
check-insize payload in accordance with relay:https://github.com/getsentry/relay/blob/ee1fc80b46968d803c4a90f6b3ed36c07955fdad/relay-config/src/config.rs#L586