Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for SENTRY_SPOTLIGHT env var in Node #13325

Merged
merged 10 commits into from
Aug 13, 2024
Merged

feat: Add support for SENTRY_SPOTLIGHT env var in Node #13325

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cf04993
feat: Add support for SENTRY_SPOTLIGHT env var in Node
Aug 12, 2024
6b973cd
Merge branch 'develop' into byk/feat/SENTRY_SPOTLIGHT
BYK Aug 12, 2024
f08ff0d
pull out into helper
Aug 13, 2024
1310252
Merge branch 'develop' into byk/feat/SENTRY_SPOTLIGHT
BYK Aug 13, 2024
67bd976
forgot strict mode
Aug 13, 2024
32c89cb
fix logic error
Aug 13, 2024
ed51040
add tests
Aug 13, 2024
1d9c633
Merge branch 'develop' into byk/feat/SENTRY_SPOTLIGHT
BYK Aug 13, 2024
7dcaa82
fix tests & add undefined case
Aug 13, 2024
3a674c2
Merge branch 'develop' into byk/feat/SENTRY_SPOTLIGHT
BYK Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/node/src/sdk/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,9 @@ export function validateOpenTelemetrySetup(): void {
}
}

const FALSY_ENV_VALUES = new Set(['0', 'false', 'no']);
const TRUTHY_ENV_VALUES = new Set(['1', 'true', 'yes']);
BYK marked this conversation as resolved.
Show resolved Hide resolved

function getClientOptions(
options: NodeOptions,
getDefaultIntegrationsImpl: (options: Options) => Integration[],
Expand All @@ -221,6 +224,17 @@ function getClientOptions(
? true
: options.autoSessionTracking;

if (options.spotlight == null && process.env.SENTRY_SPOTLIGHT) {
const spotlightEnv = process.env.SENTRY_SPOTLIGHT.toLowerCase();
if (FALSY_ENV_VALUES.has(spotlightEnv)) {
options.spotlight = false;
} else if (TRUTHY_ENV_VALUES.has(spotlightEnv)) {
options.spotlight = true;
} else {
options.spotlight = spotlightEnv;
}
}

const tracesSampleRate = getTracesSampleRate(options.tracesSampleRate);

const baseOptions = dropUndefinedKeys({
Expand Down
Loading