fix lint

getsentry · Oct 16, 2024 · abcc6cc · abcc6cc
1 parent 08ba15a
commit abcc6cc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/core/android/src/main/java/io/sentry/react/RNSentryModuleImpl.java b/packages/core/android/src/main/java/io/sentry/react/RNSentryModuleImpl.java
@@ -91,7 +91,7 @@ public class RNSentryModuleImpl {
   private static final ILogger logger = new AndroidLogger(NAME);
   private static final BuildInfoProvider buildInfo = new BuildInfoProvider(logger);
   private static final String modulesPath = "modules.json";
-  private static final Charset UTF_8 = Charset.forName(Charset.UTF_8);
+  private static final Charset UTF_8 = Charset.forName("UTF-8"); // NOPMD - Allow using UTF-8
 
   private final ReactApplicationContext reactApplicationContext;
   private final PackageInfo packageInfo;

diff --git a/...les/react-native/android/app/src/main/java/io/sentry/reactnative/sample/AssetsModule.java b/...les/react-native/android/app/src/main/java/io/sentry/reactnative/sample/AssetsModule.java
@@ -6,6 +6,7 @@
 import com.facebook.react.bridge.ReactMethod;
 import com.facebook.react.bridge.WritableArray;
 import com.facebook.react.bridge.WritableNativeArray;
+import java.io.IOException;
 import java.io.InputStream;
 
 public class AssetsModule extends ReactContextBaseJavaModule {
@@ -21,9 +22,9 @@ public String getName() {
 
   @ReactMethod
   public void getExampleAssetData(Promise promise) {
+    InputStream stream = null;
     try {
-      InputStream stream = // NOPMD - Stream is closed in finally block
-          this.getReactApplicationContext().getResources().getAssets().open("logo_mini.png");
+      stream = this.getReactApplicationContext().getResources().getAssets().open("logo_mini.png");
       int size = stream.available();
       byte[] buffer = new byte[size];
       stream.read(buffer);
@@ -36,7 +37,9 @@ public void getExampleAssetData(Promise promise) {
       promise.reject(e);
     } finally {
       try {
-        stream.close();
+        if (stream != null) {
+          stream.close();
+        }
       } catch (IOException e) {
         promise.reject(e);
       }