Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Move fetchNativeAppStart from root to package/core #4182

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix

📜 Description

During the last merge of main to v6. I forgot to move this test.

💚 How did you test it?

ci

#skip-changelog

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucas-zimerman
Copy link
Collaborator

isnt there an option to auto merge when all tests are passing?

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Good catch 🙇

@krystofwoldrich krystofwoldrich merged commit e29594d into main Oct 15, 2024
58 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/fix-bad-merge-java-test branch October 15, 2024 15:21
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 496.35 ms 529.06 ms 32.71 ms
Size 17.74 MiB 20.07 MiB 2.34 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e73d82f 475.82 ms 506.55 ms 30.73 ms
0ebca77 414.93 ms 444.49 ms 29.56 ms
484813b 434.55 ms 452.31 ms 17.75 ms
e540498 436.26 ms 433.00 ms -3.26 ms
acadc0f+dirty 373.24 ms 381.51 ms 8.27 ms
70e6261 482.65 ms 495.70 ms 13.05 ms
b1e8712 462.11 ms 465.71 ms 3.60 ms
0677344 327.74 ms 337.14 ms 9.40 ms
3ffcddd 302.92 ms 315.80 ms 12.88 ms
728164b 414.34 ms 449.22 ms 34.88 ms

App size

Revision Plain With Sentry Diff
e73d82f 17.73 MiB 20.07 MiB 2.33 MiB
0ebca77 17.73 MiB 19.95 MiB 2.21 MiB
484813b 17.73 MiB 20.07 MiB 2.33 MiB
e540498 17.73 MiB 20.11 MiB 2.37 MiB
acadc0f+dirty 17.73 MiB 19.75 MiB 2.01 MiB
70e6261 17.73 MiB 19.94 MiB 2.21 MiB
b1e8712 17.73 MiB 19.75 MiB 2.02 MiB
0677344 17.73 MiB 19.81 MiB 2.07 MiB
3ffcddd 17.73 MiB 19.75 MiB 2.02 MiB
728164b 17.73 MiB 19.85 MiB 2.12 MiB

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 415.49 ms 467.18 ms 51.69 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
700cbf4+dirty 411.71 ms 485.52 ms 73.81 ms
acadc0f+dirty 259.04 ms 304.67 ms 45.63 ms
e5c9b8b+dirty 335.40 ms 360.06 ms 24.67 ms
728164b+dirty 335.93 ms 342.94 ms 7.01 ms
abb7058+dirty 320.78 ms 324.08 ms 3.30 ms
27ef4ee+dirty 296.71 ms 351.00 ms 54.29 ms
22e31b6+dirty 295.75 ms 346.73 ms 50.98 ms
9c48b2c+dirty 270.82 ms 321.12 ms 50.30 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
1d86dd6+dirty 335.76 ms 371.22 ms 35.46 ms

App size

Revision Plain With Sentry Diff
700cbf4+dirty 7.15 MiB 8.34 MiB 1.19 MiB
acadc0f+dirty 7.15 MiB 8.03 MiB 903.20 KiB
e5c9b8b+dirty 7.15 MiB 8.10 MiB 980.41 KiB
728164b+dirty 7.15 MiB 8.12 MiB 997.71 KiB
abb7058+dirty 7.15 MiB 8.10 MiB 980.40 KiB
27ef4ee+dirty 7.15 MiB 8.08 MiB 959.49 KiB
22e31b6+dirty 7.15 MiB 8.10 MiB 981.29 KiB
9c48b2c+dirty 7.15 MiB 8.07 MiB 947.16 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
1d86dd6+dirty 7.15 MiB 8.13 MiB 1002.18 KiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.25 ms 1225.04 ms -0.21 ms
Size 2.36 MiB 3.09 MiB 742.67 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e5c9b8b+dirty 1258.57 ms 1267.32 ms 8.75 ms
0db0c72+dirty 1275.02 ms 1285.84 ms 10.82 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
1c65324+dirty 1235.17 ms 1235.08 ms -0.09 ms
e2b64fe+dirty 1232.22 ms 1255.20 ms 22.98 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms
5571a20+dirty 1203.57 ms 1204.57 ms 1.00 ms
e73f4ed+dirty 1243.27 ms 1244.52 ms 1.25 ms
e73d82f+dirty 1207.52 ms 1216.73 ms 9.21 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms

App size

Revision Plain With Sentry Diff
e5c9b8b+dirty 2.36 MiB 2.87 MiB 520.43 KiB
0db0c72+dirty 2.36 MiB 2.84 MiB 487.01 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
1c65324+dirty 2.36 MiB 3.04 MiB 698.64 KiB
e2b64fe+dirty 2.36 MiB 2.85 MiB 495.80 KiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB
5571a20+dirty 2.36 MiB 2.92 MiB 569.93 KiB
e73f4ed+dirty 2.36 MiB 2.82 MiB 469.44 KiB
e73d82f+dirty 2.36 MiB 3.08 MiB 734.23 KiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1237.51 ms 1228.79 ms -8.72 ms
Size 2.92 MiB 3.64 MiB 744.12 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e5c9b8b+dirty 1276.90 ms 1280.92 ms 4.02 ms
0db0c72+dirty 1258.88 ms 1262.52 ms 3.64 ms
76d1baf+dirty 1245.00 ms 1257.76 ms 12.76 ms
1c65324+dirty 1239.71 ms 1239.86 ms 0.15 ms
e2b64fe+dirty 1285.78 ms 1297.56 ms 11.78 ms
8900e1a+dirty 1268.36 ms 1273.04 ms 4.68 ms
5571a20+dirty 1228.09 ms 1233.45 ms 5.36 ms
e73f4ed+dirty 1282.90 ms 1309.30 ms 26.40 ms
e73d82f+dirty 1231.20 ms 1228.81 ms -2.40 ms
d7401ac+dirty 1288.10 ms 1289.54 ms 1.44 ms

App size

Revision Plain With Sentry Diff
e5c9b8b+dirty 2.92 MiB 3.43 MiB 524.50 KiB
0db0c72+dirty 2.92 MiB 3.40 MiB 492.71 KiB
76d1baf+dirty 2.92 MiB 3.38 MiB 475.74 KiB
1c65324+dirty 2.92 MiB 3.61 MiB 705.56 KiB
e2b64fe+dirty 2.92 MiB 3.41 MiB 499.97 KiB
8900e1a+dirty 2.92 MiB 3.39 MiB 485.96 KiB
5571a20+dirty 2.92 MiB 3.48 MiB 575.54 KiB
e73f4ed+dirty 2.92 MiB 3.38 MiB 475.71 KiB
e73d82f+dirty 2.92 MiB 3.64 MiB 740.56 KiB
d7401ac+dirty 2.92 MiB 3.40 MiB 488.06 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants