chore(ci): Use concurrency instead of third party action, main runs all jobs #4195

krystofwoldrich · 2024-10-21T10:24:12Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

This PR removes the cancel previous runs jobs as they are not needed when using concurrency.

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs

💡 Motivation and Context

every commit on main should finish all jobs

💚 How did you test it?

ci

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

…ll jobs

github-actions · 2024-10-21T10:45:41Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	381.83 ms	427.94 ms	46.11 ms
Size	7.15 MiB	8.35 MiB	1.20 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`52c0562`+dirty	401.23 ms	435.65 ms	34.42 ms
`d197b5c`+dirty	258.75 ms	313.61 ms	54.86 ms
`2ec71da`+dirty	375.64 ms	431.59 ms	55.95 ms
`b95b8af`+dirty	392.94 ms	428.00 ms	35.06 ms
`4a6664f`+dirty	357.02 ms	394.91 ms	37.89 ms
`0db0c72`+dirty	335.20 ms	351.06 ms	15.86 ms
`0677344`+dirty	288.40 ms	391.44 ms	103.04 ms
`e2b64fe`+dirty	258.82 ms	304.26 ms	45.44 ms
`76d1baf`+dirty	339.02 ms	408.65 ms	69.63 ms
`9a3ca65`+dirty	344.96 ms	358.92 ms	13.96 ms

App size

Revision	Plain	With Sentry	Diff
`52c0562`+dirty	7.15 MiB	8.39 MiB	1.24 MiB
`d197b5c`+dirty	7.15 MiB	8.09 MiB	962.72 KiB
`2ec71da`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`b95b8af`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`4a6664f`+dirty	7.15 MiB	8.22 MiB	1.07 MiB
`0db0c72`+dirty	7.15 MiB	8.04 MiB	911.02 KiB
`0677344`+dirty	7.15 MiB	8.07 MiB	949.80 KiB
`e2b64fe`+dirty	7.15 MiB	8.07 MiB	947.16 KiB
`76d1baf`+dirty	7.15 MiB	8.09 MiB	964.41 KiB
`9a3ca65`+dirty	7.15 MiB	8.09 MiB	962.83 KiB

github-actions · 2024-10-21T10:51:35Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1217.98 ms	1223.38 ms	5.41 ms
Size	2.36 MiB	3.10 MiB	752.80 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`34aba08`+dirty	1276.78 ms	1308.52 ms	31.74 ms
`457e29f`+dirty	1253.94 ms	1269.18 ms	15.24 ms
`9a3ca65`+dirty	1247.06 ms	1274.58 ms	27.52 ms
`b95b8af`+dirty	1221.39 ms	1228.52 ms	7.13 ms
`70caa60`+dirty	1218.27 ms	1230.30 ms	12.03 ms
`d197b5c`+dirty	1217.61 ms	1242.66 ms	25.05 ms
`5446992`+dirty	1273.28 ms	1276.68 ms	3.40 ms
`e73f4ed`+dirty	1243.27 ms	1244.52 ms	1.25 ms
`2534337`+dirty	1225.08 ms	1230.26 ms	5.17 ms
`5a22220`+dirty	1209.49 ms	1220.94 ms	11.45 ms

App size

Revision	Plain	With Sentry	Diff
`34aba08`+dirty	2.36 MiB	2.85 MiB	495.32 KiB
`457e29f`+dirty	2.36 MiB	2.87 MiB	520.67 KiB
`9a3ca65`+dirty	2.36 MiB	2.82 MiB	462.89 KiB
`b95b8af`+dirty	2.36 MiB	3.14 MiB	793.32 KiB
`70caa60`+dirty	2.36 MiB	2.83 MiB	479.27 KiB
`d197b5c`+dirty	2.36 MiB	2.82 MiB	462.86 KiB
`5446992`+dirty	2.36 MiB	2.88 MiB	531.94 KiB
`e73f4ed`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`2534337`+dirty	2.36 MiB	2.88 MiB	525.47 KiB
`5a22220`+dirty	2.36 MiB	2.92 MiB	570.21 KiB

github-actions · 2024-10-21T10:56:17Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1227.96 ms	1233.68 ms	5.72 ms
Size	2.92 MiB	3.66 MiB	758.04 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`34aba08`+dirty	1268.58 ms	1276.80 ms	8.22 ms
`457e29f`+dirty	1256.71 ms	1258.50 ms	1.79 ms
`9a3ca65`+dirty	1276.40 ms	1279.14 ms	2.74 ms
`b95b8af`+dirty	1235.60 ms	1242.06 ms	6.46 ms
`70caa60`+dirty	1279.08 ms	1281.54 ms	2.46 ms
`d197b5c`+dirty	1234.80 ms	1249.20 ms	14.40 ms
`5446992`+dirty	1249.94 ms	1254.80 ms	4.86 ms
`e73f4ed`+dirty	1282.90 ms	1309.30 ms	26.40 ms
`2534337`+dirty	1220.87 ms	1221.47 ms	0.60 ms
`5a22220`+dirty	1246.18 ms	1249.61 ms	3.43 ms

App size

Revision	Plain	With Sentry	Diff
`34aba08`+dirty	2.92 MiB	3.41 MiB	499.03 KiB
`457e29f`+dirty	2.92 MiB	3.43 MiB	524.75 KiB
`9a3ca65`+dirty	2.92 MiB	3.37 MiB	464.32 KiB
`b95b8af`+dirty	2.92 MiB	3.69 MiB	794.16 KiB
`70caa60`+dirty	2.92 MiB	3.39 MiB	486.04 KiB
`d197b5c`+dirty	2.92 MiB	3.37 MiB	464.41 KiB
`5446992`+dirty	2.92 MiB	3.44 MiB	535.26 KiB
`e73f4ed`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`2534337`+dirty	2.92 MiB	3.43 MiB	529.76 KiB
`5a22220`+dirty	2.92 MiB	3.48 MiB	575.81 KiB

antonis

LGTM 🚀

github-actions · 2024-10-21T11:46:00Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	454.17 ms	471.88 ms	17.71 ms
Size	17.74 MiB	20.07 MiB	2.34 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d197b5c`+dirty	338.94 ms	354.87 ms	15.93 ms
`3ffcddd`	302.92 ms	315.80 ms	12.88 ms
`700cbf4`	425.56 ms	436.26 ms	10.70 ms
`9433f35`	347.64 ms	356.22 ms	8.58 ms
`70e6261`	482.65 ms	495.70 ms	13.05 ms
`4a6664f`	548.79 ms	585.00 ms	36.21 ms
`5a22220`	412.38 ms	447.35 ms	34.97 ms
`b1e8712`	462.11 ms	465.71 ms	3.60 ms
`0db0c72`	372.12 ms	386.00 ms	13.88 ms
`ac41368`	451.47 ms	453.67 ms	2.20 ms

App size

Revision	Plain	With Sentry	Diff
`d197b5c`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`3ffcddd`	17.73 MiB	19.75 MiB	2.02 MiB
`700cbf4`	17.73 MiB	20.07 MiB	2.33 MiB
`9433f35`	17.73 MiB	19.81 MiB	2.08 MiB
`70e6261`	17.73 MiB	19.94 MiB	2.21 MiB
`4a6664f`	17.73 MiB	19.94 MiB	2.21 MiB
`5a22220`	17.73 MiB	19.93 MiB	2.20 MiB
`b1e8712`	17.73 MiB	19.75 MiB	2.02 MiB
`0db0c72`	17.73 MiB	19.75 MiB	2.02 MiB
`ac41368`	17.73 MiB	20.11 MiB	2.38 MiB

chore(ci): Use concurrency instead of third party action, main runs a…

99848d9

…ll jobs

krystofwoldrich requested review from lucas-zimerman and antonis as code owners October 21, 2024 10:24

antonis approved these changes Oct 21, 2024

View reviewed changes

add concurrency to build and test and codegen tests

6ea3c9c

krystofwoldrich enabled auto-merge (squash) October 21, 2024 11:36

krystofwoldrich merged commit 6ffa59a into main Oct 21, 2024
53 checks passed

krystofwoldrich deleted the kw/ci/main-run-all-jobs branch October 21, 2024 11:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ci): Use concurrency instead of third party action, main runs all jobs #4195

chore(ci): Use concurrency instead of third party action, main runs all jobs #4195

krystofwoldrich commented Oct 21, 2024

github-actions bot commented Oct 21, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Oct 21, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Oct 21, 2024 •

edited

Loading

Baseline results on branch: main

Startup times

App size

antonis left a comment

github-actions bot commented Oct 21, 2024

Baseline results on branch: main

Startup times

App size

chore(ci): Use concurrency instead of third party action, main runs all jobs #4195

chore(ci): Use concurrency instead of third party action, main runs all jobs #4195

Conversation

krystofwoldrich commented Oct 21, 2024

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Oct 21, 2024 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Oct 21, 2024 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Oct 21, 2024 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

antonis left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 21, 2024

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading

github-actions bot commented Oct 21, 2024 •

edited

Loading