Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable building sentry-tower and sentry-tracing with all features on docs.rs #611

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Enable building sentry-tower and sentry-tracing with all features on docs.rs #611

merged 1 commit into from
Sep 13, 2023

Conversation

FSMaxB
Copy link
Contributor

@FSMaxB FSMaxB commented Sep 13, 2023

I found e.g. SentryHttpLayer missing from docs.rs for sentry-tower so I went ahead and added the necessary docs.rs metadata to Cargo.toml for sentry-tower and sentry-tracing (those were the packages with non-default features that didn't have it enabled yet).

loewenheim
loewenheim approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@loewenheim loewenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@loewenheim
Copy link
Contributor

Would you mind merging or rebasing on top of master? We had some cleanup to do.

@loewenheim loewenheim enabled auto-merge (squash) September 13, 2023 14:39
@loewenheim loewenheim merged commit 10c5640 into getsentry:master Sep 13, 2023
12 checks passed
@loewenheim
Copy link
Contributor

Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loewenheim loewenheim loewenheim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FSMaxB @loewenheim