Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crons): Add new fields to MonitorConfig type #638

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

szokeasaurusrex
Copy link
Member

Need these fields to implement getsentry/sentry-cli#1919

@szokeasaurusrex szokeasaurusrex requested review from Swatinem, evanpurkhiser and loewenheim and removed request for evanpurkhiser January 29, 2024 17:11
@szokeasaurusrex szokeasaurusrex self-assigned this Jan 29, 2024
@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) January 29, 2024 17:13
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab38648) 73.11% compared to head (dd6c988) 73.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #638      +/-   ##
==========================================
+ Coverage   73.11%   73.23%   +0.11%     
==========================================
  Files          62       62              
  Lines        7518     7550      +32     
==========================================
+ Hits         5497     5529      +32     
  Misses       2021     2021              

@szokeasaurusrex szokeasaurusrex merged commit bd78e1e into master Jan 29, 2024
13 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/new-monitor-config-fields branch January 29, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants