Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make regex an optional dependency #659

Merged
merged 1 commit into from
May 28, 2024
Merged

Make regex an optional dependency #659

merged 1 commit into from
May 28, 2024

Conversation

dbanty
Copy link
Contributor

@dbanty dbanty commented May 27, 2024

The latest release includes regex and family—I'd very much like to avoid those if possible, since they are big chunky crates with slow compile times.

For now, the easiest thing seems to be to gate the inclusion of regex on UNSTABLE_metrics since it is only used in that code path.

Longer-term, I'd appreciate either reverting to the pre- #658 implementation that looks something like c.is_ascii_alphanumeric() || matches!(c, '_' | '-' | '.' | '/') (since it's a relatively simple regex) or looking into a lighter crate like regex-lite.

@Swatinem Swatinem enabled auto-merge (squash) May 28, 2024 07:20
@Swatinem Swatinem merged commit 7492d24 into getsentry:master May 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants