Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add server_name to transaction data #694

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

nrxus
Copy link
Contributor

@nrxus nrxus commented Oct 3, 2024

Currently transactions do not include a server_name which makes it harder to know where a transaction occurred.

According to the transaction docs:

Transactions are Events enriched with Span data

And the events docs include server_name so I don't see any reason not to include it.

Perhaps in the future it might make more sense to have a common struct between the two that gets flattened (through serde) such that when Event gets new fields that may be useful in a Transaction then it'll already be there (as long as the function to enrich that hypothetical shared struct is used in both places). This, however, is outside of the scope of what I need at this time so I only did the smallest thing I needed.

@Swatinem Swatinem merged commit d0585b6 into getsentry:master Oct 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants