Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(stories): Update usePrismTokens to demonstrate the raw hook output #62229

Merged
merged 2 commits into from
Dec 22, 2023
Merged

docs(stories): Update usePrismTokens to demonstrate the raw hook output #62229

merged 2 commits into from
Dec 22, 2023

Conversation

ryan953
Copy link
Member

@ryan953 ryan953 commented Dec 21, 2023 •
edited
Loading

SCR-20231221-oklt

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 21, 2023
@ryan953 ryan953 requested review from malwilley and a team December 21, 2023 21:21
malwilley
malwilley approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@malwilley malwilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is much more useful 💯

For some reason I'm seeing this:

CleanShot 2023-12-21 at 13 24 28

@ryan953
Copy link
Member Author

ryan953 commented Dec 21, 2023

Thanks, this is much more useful 💯

For some reason I'm seeing this:

CleanShot 2023-12-21 at 13 24 28

@malwilley ah, that's the hook name after it got built i guess :(
that sucks. I'll have to go back to making it a string.

@ryan953
Copy link
Member Author

ryan953 commented Dec 21, 2023

@malwilley see getsentry/develop#1115

@ryan953 ryan953 mentioned this pull request Dec 21, 2023
Merged
@ryan953 ryan953 merged commit a61e363 into master Dec 22, 2023
40 checks passed
@ryan953 ryan953 deleted the ryan953/storyBook-hook-name branch December 22, 2023 18:42
@ryan953 ryan953 restored the ryan953/storyBook-hook-name branch January 2, 2024 16:56
armenzg pushed a commit that referenced this pull request Jan 8, 2024
@ryan953 @armenzg
docs(stories): Update usePrismTokens to demonstrate the raw hook outp…
a240f53 
…ut (#62229)

<img width="1287" alt="SCR-20231221-oklt"
src="https://github.com/getsentry/sentry/assets/187460/cbb08706-e452-4902-b04b-e254e1098ff7">
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@malwilley malwilley malwilley approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan953 @malwilley