-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(errors): Add YAML definitions for new features columns #6724
feat(errors): Add YAML definitions for new features columns #6724
Conversation
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This is set in the runtime config for Snuba. |
…github.com/getsentry/snuba into cmanallen/errors-features-yaml-definitions
@evanh I had to update the replacer test coverage. Hopefully this is fine or do I need to update elsewhere? The diff might be hard to read. The change is just adding the flag columns to the query. cc @untitaker since I think you worked on this too? |
Adds YAML definitions for the new
features
columns and index. These columns will allow us to search for errors by feature flag.TODO:
events_features_hash_map_enabled
. Where is this defined?DACI: https://www.notion.so/sentry/DACI-Search-for-Errors-by-Feature-Flag-1288b10e4b5d8014976dcbfbf335bc37?pvs=4#1288b10e4b5d805eb476d313eecae009
Depends on: #6723
Closes: https://github.com/getsentry/team-replay/issues/519