Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(errors): Add YAML definitions for new features columns #6724

Merged
merged 11 commits into from
Jan 23, 2025

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Jan 8, 2025

Adds YAML definitions for the new features columns and index. These columns will allow us to search for errors by feature flag.

TODO:

  • Needs killswitch definition for: events_features_hash_map_enabled. Where is this defined?

DACI: https://www.notion.so/sentry/DACI-Search-for-Errors-by-Feature-Flag-1288b10e4b5d8014976dcbfbf335bc37?pvs=4#1288b10e4b5d805eb476d313eecae009
Depends on: #6723
Closes: https://github.com/getsentry/team-replay/issues/519

@cmanallen cmanallen marked this pull request as ready for review January 8, 2025 16:41
@cmanallen cmanallen requested review from a team as code owners January 8, 2025 16:41
Copy link

codecov bot commented Jan 8, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2015 1 2014 11
View the top 1 failed tests by shortest run time
tests.query.processors.test_empty_tag_condition_processor::test_empty_tag_condition[not equals on empty string converted to has on tags key]
Stack Traces | 0.002s run time
Traceback (most recent call last):
  File ".../query/processors/test_empty_tag_condition_processor.py", line 160, in test_empty_tag_condition
    processor = EmptyTagConditionProcessor()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: EmptyTagConditionProcessor.__init__() missing 1 required positional argument: 'column_name'

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@evanh
Copy link
Member

evanh commented Jan 13, 2025

Needs killswitch definition for: events_features_hash_map_enabled. Where is this defined?

This is set in the runtime config for Snuba.

@cmanallen
Copy link
Member Author

@evanh I had to update the replacer test coverage. Hopefully this is fine or do I need to update elsewhere? The diff might be hard to read. The change is just adding the flag columns to the query.

cc @untitaker since I think you worked on this too?

@cmanallen cmanallen requested a review from evanh January 22, 2025 15:47
@cmanallen cmanallen merged commit e3a17f7 into master Jan 23, 2025
31 checks passed
@cmanallen cmanallen deleted the cmanallen/errors-features-yaml-definitions branch January 23, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants