-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(EAP): Trace Item resolvers #6732
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2432802
initial skeleton
volokluev 13a57ac
trace item table tests work, need to move logic into resolver
volokluev 5db852c
move front facing logic to resolver
volokluev 423a028
add actual resolver code
volokluev fbf8c8e
move aggregations
volokluev ce0c18f
add agg files
volokluev 769e9c1
move timeseries to resolver
volokluev e62949b
move timeseries to resolver
volokluev ae2c2b5
davids fixes
volokluev 21811ca
[getsentry/action-github-commit] Auto commit
getsantry[bot] dd2a609
mypy/test fix
volokluev d962e4e
aggregation changes from master
volokluev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,7 @@ | |
from google.protobuf.message import DecodeError | ||
from google.protobuf.message import Message as ProtobufMessage | ||
from sentry_protos.snuba.v1.error_pb2 import Error as ErrorProto | ||
from sentry_protos.snuba.v1.request_common_pb2 import TraceItemName | ||
|
||
from snuba import environment | ||
from snuba.utils.metrics.backends.abstract import MetricsBackend | ||
|
@@ -25,6 +26,42 @@ | |
Tout = TypeVar("Tout", bound=ProtobufMessage) | ||
|
||
|
||
class TraceItemDataResolver(Generic[Tin, Tout], metaclass=RegisteredClass): | ||
def __init__( | ||
self, timer: Timer | None = None, metrics_backend: MetricsBackend | None = None | ||
) -> None: | ||
self._timer = timer or Timer("endpoint_timing") | ||
self._metrics_backend = metrics_backend or environment.metrics | ||
|
||
@classmethod | ||
def config_key(cls) -> str: | ||
return f"{cls.endpoint_name()}__{cls.trace_item_name()}" | ||
|
||
@classmethod | ||
def endpoint_name(cls) -> str: | ||
if cls.__name__ == "TraceItemDataResolver": | ||
return cls.__name__ | ||
raise NotImplementedError | ||
|
||
@classmethod | ||
def trace_item_name(cls) -> TraceItemName.ValueType: | ||
return TraceItemName.TRACE_ITEM_NAME_UNSPECIFIED | ||
|
||
@classmethod | ||
def get_from_trace_item_name( | ||
cls, trace_item_name: TraceItemName.ValueType | ||
) -> "Type[TraceItemDataResolver[Tin, Tout]]": | ||
return cast( | ||
Type["TraceItemDataResolver[Tin, Tout]"], | ||
getattr(cls, "_registry").get_class_from_name( | ||
f"{cls.endpoint_name()}__{trace_item_name}" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From my understanding There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. correct |
||
), | ||
) | ||
|
||
def resolve(self, in_msg: Tin) -> Tout: | ||
raise NotImplementedError | ||
|
||
|
||
class RPCEndpoint(Generic[Tin, Tout], metaclass=RegisteredClass): | ||
def __init__(self, metrics_backend: MetricsBackend | None = None) -> None: | ||
self._timer = Timer("endpoint_timing") | ||
|
@@ -46,6 +83,11 @@ def version(cls) -> str: | |
def config_key(cls) -> str: | ||
return f"{cls.__name__}__{cls.version()}" | ||
|
||
def get_resolver( | ||
self, trace_item_name: TraceItemName.ValueType | ||
) -> TraceItemDataResolver[Tin, Tout]: | ||
raise NotImplementedError | ||
|
||
@property | ||
def metrics(self) -> MetricsWrapper: | ||
return MetricsWrapper( | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm missing something, but where is this _registry attribute being set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the RegisteredClass metaclass