fix(admin): Import bootstrap CSS properly #6795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently I forgot to do this when moving to esbuild, and as a result bootstrap was never initialized. This broke the edit modal in cardinality analyzer. It took a while to notice this issue though, so I wonder if bootstrap can be removed entirely in favor of mantine.
evanh
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently I forgot to do this when moving to esbuild, and as a result
bootstrap was never initialized.
This broke the edit modal in cardinality analyzer.
It took a while to notice this issue though, so I wonder if bootstrap
can be removed entirely in favor of mantine.