-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: Add EndpointTraceItemStats RPC #6809
Draft
shruthilayaj
wants to merge
5
commits into
master
Choose a base branch
from
shruthi/feat/add-EndpointTraceItemStats-RPC
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+439
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shruthilayaj
commented
Jan 23, 2025
Comment on lines
+108
to
+135
concat_attr_maps = FunctionCall( | ||
alias="attr_str_concat", | ||
function_name="mapConcat", | ||
parameters=tuple(column(f"attr_str_{i}") for i in range(ATTRIBUTE_BUCKETS)), | ||
) | ||
attrs_string_keys = tupleElement( | ||
"attr_key", arrayJoin("attr_str", concat_attr_maps), Literal(None, 1) | ||
) | ||
attrs_string_values = tupleElement( | ||
"attr_value", | ||
arrayJoin("attr_str", concat_attr_maps), | ||
Literal(None, 2), | ||
) | ||
|
||
selected_columns = [ | ||
SelectedExpression( | ||
name="attr_key", | ||
expression=attrs_string_keys, | ||
), | ||
SelectedExpression( | ||
name="attr_value", | ||
expression=attrs_string_values, | ||
), | ||
SelectedExpression( | ||
name=aggregation.label, | ||
expression=aggregation_to_expression(aggregation), | ||
), | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SELECT
(arrayJoin(mapConcat(attr_str_0, attr_str_1, attr_str_2, attr_str_3, attr_str_4, attr_str_5, attr_str_6, attr_str_7, attr_str_8, attr_str_9, attr_str_10, attr_str_11, attr_str_12, attr_str_13, attr_str_14, attr_str_15, attr_str_16, attr_str_17, attr_str_18, attr_str_19) AS attr_str_concat) AS attr_str).1 AS attr_keys,
attr_str.2 AS attr_values,
sumIf(sign * sampling_weight, ((duration_micro / 1000) AS `sentry.duration_ms`) IS NOT NULL) AS count
FROM eap_spans_2_local
WHERE (project_id IN [1, 2, 3]) AND (organization_id = 1) AND less(_sort_timestamp, toDateTime(1737500400)) AND greaterOrEquals(_sort_timestamp, toDateTime(1737489600)) AND true
GROUP BY
attr_keys,
attr_values
ORDER BY count DESC
LIMIT 10 BY attr_keys
LIMIT 0, 100
the resulting query looks like this ^
https://www.notion.so/sentry/Naive-approach-for-stats-endpoint-1848b10e4b5d80708bcffa341e0f225a
ran this query locally and on snuba admin, documented results - snuba admin is being a little buggy so couldn't do something more comprehensive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires getsentry/sentry-protos#101
For comparison workflows, we need the count distribution data of all attribute/value pairs (both string and numeric, however we'll focus on string first). We're introducing a trace item stats endpoint to facilitate that. The aim is to build a somewhat generic endpoint that can give a high level overview of the shape of your data.
This implementation is fairly simple, restricted to string attributes to begin with. It returns the frequency distribution of attributes in the requested filter. The data returned is ordered by keys that have the highest frequency attribute values.