fix: Don't persist cache files that error while writing #1579
+104
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an early return in
memory.rs
so that if anInternalError
is returned by a cache computation¹, we don't attempt to write the error and don't persist the temp file. This kills two birds with one stone:InternalError
because of lack of disk space, we discard the resulting file immediately instead of preserving its (likely useless) contents.Moreover, I also added some extra validation after
symcache
/ppdbcache
/sourcemapcache
conversion. Now, if somehow the write goes through but the file is invalid, we also return anInternalError
and it will be deleted. This costs us nothing because parsing these files is essentially free. I thought about doing the same forcficache
files, but there the tradeoff is less clear—parsing them takes significant resources, for a case we don't know ever occurs.¹ Caused by an
io::Error
, for instance.