fix: allow optional abs_path and lineno for JsFrame #1581
+67
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelmaddock
force-pushed
the
fix/optional-frame-props
branch
from
829c938 to
13cc9d3
Compare
samuelmaddock
force-pushed
the
fix/optional-frame-props
branch
from
13cc9d3 to
2b799fe
Compare
Dav1dde
reviewed
Jan 9, 2025
|
|
||
| let module = lookup.get_module(&raw_frame.abs_path).await; | ||
| let module = lookup.get_module(&abs_path).await; |
There was a problem hiding this comment.
Not sure what we should do here, we're fetching the module identified by "" here. This seems wrong.
There was a problem hiding this comment.
I found there was an unused JsModuleErrorKind::InvalidAbsPath which fits here nicely. b381fe3
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1581 +/- ##
==========================================
- Coverage 76.09% 73.77% -2.32%
==========================================
Files 101 105 +4
Lines 15262 16186 +924
==========================================
+ Hits 11613 11941 +328
- Misses 3649 4245 +596 |
Co-authored-by: David Herberth <github@dav1d.de>
Co-authored-by: David Herberth <github@dav1d.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1580
It's possible for V8 to format a JS frame location to only contain
<anonymous>(see AppendFileLocation). In such cases, JSON deserialization should pass, but symbolification should fail.Here's an example call stack this addresses:
Also, this is the first Rust code I've written so please lmk what can be improved!