feat(tests): End-to-end integration for upkeep retry #112
+479
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-z-yang
approved these changes
Jan 9, 2025
markstory
reviewed
Jan 9, 2025
Comment on lines
+94
to
+96
| else: | ||
| time.sleep(1) | ||
| continue |
There was a problem hiding this comment.
In the event that not all tasks are processed should we have a max time we'll wait for completion?
There was a problem hiding this comment.
We should! Added a timeout for taskworkers.
Comment on lines
170
to
178
| def check_num_tasks_written(consumer_config: dict) -> int: | ||
| attach_db_stmt = f"ATTACH DATABASE '{consumer_config['db_path']}' AS {consumer_config['db_name']};\n" | ||
| query = f"""SELECT count(*) as count FROM {consumer_config['db_name']}.inflight_taskactivations;""" | ||
| con = sqlite3.connect(consumer_config["db_path"]) | ||
| cur = con.cursor() | ||
| cur.executescript(attach_db_stmt) | ||
| rows = cur.execute(query).fetchall() | ||
| count = rows[0][0] | ||
| return count |
There was a problem hiding this comment.
This function shows up in a few integration tests, perhaps we should have a module of common integration test helpers?
There was a problem hiding this comment.
Good catch, lifted the function and consumer configs to helpers.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this test do?
This tests is responsible for checking the integrity of the retry mechanism implemented in the upkeep thread of taskbroker. An initial amount of messages is produced to kafka with a set number of retries in its retry policy. Then, the taskworkers fetch and update the task's status to retry. During an interval, the upkeep thread will collect these tasks and re-produce the task to kafka. This process continues until all tasks have been retried the specified number of times.
How does it accomplish this?
The test starts N number of taskworker(s) and a consumer in separate
threads. Synchronization events are use to instruct the taskworker(s) when start processing and shutdown. A shared data structured access by a mutex called TaskRetriedCounter is used to globally keep track of every task retried. Finally, this total number is validated alongside the number of times each individual task was retried.