Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab App - How to change the root password #1543

Conversation

DavidGarciaCat
Copy link
Contributor

This is updating the description of the app so we all know how to change the password for the root user when installing the app for the very first time.

I have tested it with my local install (umbrel home) and I got it from this page: https://stackoverflow.com/questions/55747402/docker-gitlab-change-forgotten-root-password

Copy link

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

@nmfretz
Copy link
Contributor

nmfretz commented Oct 1, 2024

Thanks for this PR @DavidGarciaCat. Changing both the username and password for the root user is all available from within the app's UI, which is something fairly common across apps that people would likely find just by exploring.

With that in mind, should we refrain from adding additional instructions in the app description, especially ones that require terminal commands?

Changing username:
image

Changing password:
image

@nmfretz nmfretz mentioned this pull request Oct 3, 2024
@nmfretz
Copy link
Contributor

nmfretz commented Oct 3, 2024

@DavidGarciaCat I'm closing this PR, but linking to it here for our consideration when updating Gitlab to the latest release:
#1564

@nmfretz nmfretz closed this Oct 3, 2024
@DavidGarciaCat
Copy link
Contributor Author

Hey, @nmfretz

According to the Umbrel App yaml file, we only see the default username (root) but no password. Shall I assume there's no password? If that't the case, then maybe we should add a note for this:

defaultUsername: "root"

@nmfretz
Copy link
Contributor

nmfretz commented Oct 3, 2024

Ah, okay I see the confusion now!

According to the Umbrel App yaml file, we only see the default username (root) but no password. Shall I assume there's no password?

There actually is a password and it is shown to the user. It is a deterministically derived password that is unique to a user's umbrel installation + app (https://github.com/getumbrel/umbrel/blob/7103e98909041bb8e15702b4b2e3e7f78da4b351/packages/umbreld/source/modules/apps/legacy-compat/app-script#L69-L88).

In the umbrel-app.yml file it is assigned here:

deterministicPassword: true

And in the compose file it is assigned here:

gitlab_rails['initial_root_password'] = '${APP_PASSWORD}'

But those details themselves don't matter to users because they don't need to know or care about an app's underlying config files. Instead they'll see the password in the app store when they install the app:

image

and as well if they right click an app icon and select "show default credentials"

image image

In a future umbrelOS update we also plan to have a notification come up the first time an app is clicked letting the user know of the default credentials.

@DavidGarciaCat
Copy link
Contributor Author

Ah !! I see, this is the same approach used for Pi-hole.

OK, thanks for the update. And yes, that makes this PR completely unnecessary.

Thanks!

Screenshot 2024-10-03 at 14 10 26

@DavidGarciaCat DavidGarciaCat deleted the gitlab-how-to-change-root-password branch October 3, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants