-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitlab App - How to change the root
password
#1543
Gitlab App - How to change the root
password
#1543
Conversation
🎉 Linting finished with no errors or warnings 🎉Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store. |
Thanks for this PR @DavidGarciaCat. Changing both the username and password for the With that in mind, should we refrain from adding additional instructions in the app description, especially ones that require terminal commands? |
@DavidGarciaCat I'm closing this PR, but linking to it here for our consideration when updating Gitlab to the latest release: |
Hey, @nmfretz According to the Umbrel App yaml file, we only see the default username (root) but no password. Shall I assume there's no password? If that't the case, then maybe we should add a note for this: umbrel-apps/gitlab/umbrel-app.yml Line 61 in ce53944
|
Ah, okay I see the confusion now!
There actually is a password and it is shown to the user. It is a deterministically derived password that is unique to a user's umbrel installation + app (https://github.com/getumbrel/umbrel/blob/7103e98909041bb8e15702b4b2e3e7f78da4b351/packages/umbreld/source/modules/apps/legacy-compat/app-script#L69-L88). In the umbrel-apps/gitlab/umbrel-app.yml Line 60 in 9dc50f8
And in the compose file it is assigned here: umbrel-apps/gitlab/docker-compose.yml Line 24 in 9dc50f8
But those details themselves don't matter to users because they don't need to know or care about an app's underlying config files. Instead they'll see the password in the app store when they install the app: and as well if they right click an app icon and select "show default credentials" In a future umbrelOS update we also plan to have a notification come up the first time an app is clicked letting the user know of the default credentials. |
This is updating the description of the app so we all know how to change the password for the
root
user when installing the app for the very first time.I have tested it with my local install (umbrel home) and I got it from this page: https://stackoverflow.com/questions/55747402/docker-gitlab-change-forgotten-root-password