Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nextcloud to version v30.0.0 #1547

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Conversation

nmfretz
Copy link
Contributor

@nmfretz nmfretz commented Sep 26, 2024

🤖 This is an automated pull request to update nextcloud to version v30.0.0. This PR must be reviewed and tested before merging.

@nmfretz
Copy link
Contributor Author

nmfretz commented Sep 26, 2024

🤖 This is an automated summary of installation tests for nextcloud:

  • ✅ App successfully installed in umbrel-dev VM
  • ✅ App successfully listed in umbrel.yaml
  • ✅ App UI successfully returns a 200 status code
  • 📸 Screenshot of the app:
    App Screenshot

This PR must still be reviewed and tested before merging.

@nmfretz
Copy link
Contributor Author

nmfretz commented Sep 26, 2024

This will require a rewrite of the pre-start script to properly handle migrations now that we are on v30

Copy link

github-actions bot commented Oct 1, 2024

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity File Description
ℹ️ nextcloud/docker-compose.yml Potentially using unsafe user in service "web":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
ℹ️ nextcloud/docker-compose.yml Potentially using unsafe user in service "cron":
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.

Legend

Symbol Description
Error: This must be resolved before this PR can be merged.
⚠️ Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️ Info: This is just for your information.

@nmfretz
Copy link
Contributor Author

nmfretz commented Oct 1, 2024

  • Updated the pre-start script to handle migration from any minor/patch version to the next major version.
  • Added v30 release notes
  • Tested fresh install
  • Tested variety of updates from up to 3 major versions ago

@nmfretz nmfretz merged commit 4511539 into master Oct 1, 2024
1 check passed
@dennysubke
Copy link

Thanks for the update!

However, I receive a warning in my Nextcloud instance about the MariaDB version in use:

“For optimal performance and stability, it is recommended to use MariaDB version > 10.6 or 11.4.”
cb1295ad0e4c1ed99cddfeb7a0ff1561b1f14345

@nmfretz
Copy link
Contributor Author

nmfretz commented Oct 1, 2024

Thanks for noting this @dennysubke! Shall we schedule the mariadb update for Nextcloud 30.0.1 which should be out soon (https://github.com/nextcloud/server/milestone/279)?

We'll need to be careful when updating mariadb and may need to run some mariadb specific migration logic in the pre-start script when we do so (https://mariadb.com/kb/en/mariadb-upgrade/).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants