Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default docker-compose.yml #1549

Closed
wants to merge 1 commit into from
Closed

Conversation

Zoobdude
Copy link

the attribute version is obsolete, it will be ignored, please remove it to avoid potential confusion

Reference in the compose-spec

Copy link

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

@nmfretz
Copy link
Contributor

nmfretz commented Sep 26, 2024

Thanks for noticing this @Zoobdude and for submitting a fix!

We are in the process of re-doing our app ecosystem on umbrelOS, which will include bringing compose files up to spec.

In the meantime though, we need to keep this legacy version attribute as-is for compatibility with umbrelOS 0.5 which is using a version of Compose that requires it (this version also requires that our app_proxy compose file and the app's main compose file have the exact same version or Compose will error out). Both umbrelOS 0.5 and 1.x use this repo, so removing or not including the version attribute would break all umbrelOS 0.5 instances.

Closing this issue, noting that we are aware of the spec. Thanks again for the sharp eyes.

@nmfretz nmfretz closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants