Update GitLab to 17.4.1

[hugofnm]

This version contains improvements, important bug and security fixes.

Warning

GitLab strongly recommend that all self-managed GitLab installations be upgraded immediately.

https://about.gitlab.com/releases/2024/09/19/gitlab-17-4-released

[github-actions]

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity	File	Description
ℹ️	gitlab/docker-compose.yml	External port mapping "2424:22": Port mappings may be unnecessary for the app to function correctly. Docker's internal DNS resolves container names to IP addresses within the same network. External access to the web interface is handled by the app_proxy container. Port mappings are only needed if external access is required to a port not proxied by the app_proxy, or if an app needs to expose multiple ports for its functionality (e.g., DHCP, DNS, P2P, etc.).

Legend

Symbol	Description
❌	Error: This must be resolved before this PR can be merged.
⚠️	Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️	Info: This is just for your information.

[nmfretz]

Thanks for this update @hugofnm! Gitlab is going to be a finicky one to update and we'll need to be careful not to break current installations.

For example, it looks like this update will break current installs (17.2.1) because Gitlab requires us to first upgrade to 17.3.x before upgrading further: https://docs.gitlab.com/ee/update/#upgrade-paths

It seems you are upgrading from 17.2.1 to 17.4.1.
It is required to upgrade to the latest 17.3.x version first before proceeding.
Please follow the upgrade documentation at https://docs.gitlab.com/ee/update/#upgrade-paths

We will need to create a pre-start bash script that detects and properly walks through the appropriate upgrade path. We'll need to do it in such a way that we are certain that each upgrade step is completed (e.g., database migrations, etc) before the next upgrade step is undertaken.

[nmfretz]

For our consideration when updating: #1543 (cc @DavidGarciaCat)

[DavidGarciaCat]

For our consideration when updating: #1543 (cc @DavidGarciaCat)

Thanks for the ping, @nmfretz. I also got this warning when logging into Gitlab, so I had it on my to-do list to send this upgrade, and I would have probably reached the same conclusion (skip one version). Knowing this PR is already open, I won't send a new one.

[nmfretz]

Thanks for the ping, @nmfretz.

You're welcome. I responded again in the other PR FYI (mentioning it here because it is closed and so we won't get notifications): #1543 (comment)