Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrum 11 #11

Merged
merged 8 commits into from
Jun 29, 2024
Merged

Scrum 11 #11

merged 8 commits into from
Jun 29, 2024

Conversation

Hsbalazs
Copy link
Contributor

Created frontend CI

Copy link
Contributor

@carlos-ponton carlos-ponton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after verifying the changes with Balázs

@AnnaUgrai AnnaUgrai self-requested a review June 27, 2024 19:28
Copy link
Collaborator

@AnnaUgrai AnnaUgrai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you changed the properties for the frontend CI ?

@Hsbalazs
Copy link
Contributor Author

Application properties was changed because some lines were duplicated at my file and I pushed it. Now it is fine.

Copy link
Contributor

@markkovari markkovari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looking strong. Only a few questions from my side.

.github/workflows/frontend-ci.yaml Outdated Show resolved Hide resolved
Hsbalazs and others added 2 commits June 29, 2024 09:13
@AnnaUgrai AnnaUgrai merged commit a3ddd41 into main Jun 29, 2024
2 checks passed
@AnnaUgrai AnnaUgrai deleted the SCRUM-11 branch June 29, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants